Add TCPC driver for RT1715 #81109

recalci · 2024-11-07T23:28:15Z

Add TCPCI functions and add driver for Richtek RT1715.

drivers/usb_c/tcpc/tcpci.c

drivers/usb_c/tcpc/rt1715.c

keith-zephyr · 2024-12-12T19:13:36Z

drivers/usb_c/tcpc/rt1715.c

Why are you enabling both SOP' and SOP'' messages here?

I noticed that both Numaker and STM32 enable them as well. However, I couldn't find the datasheet for the PS8xxx series, so I suspect that it may not support SOP'' messages.

The PS8xxx does support SOP' and SOP''. However, the API documentation for tcpc_sop_prime_enable() indicates this command is used to enable SOP' messages, with no mention of SOP''.

The ChromeOS code that USB-C support is based on does enable SOP' and SOP'' for this command.

Do you mind updating the documentation for tcpc_sop_prime_enable() to note that this enables both SOP' and SOP''?

Done. Please review.

keith-zephyr · 2024-12-18T17:14:20Z

drivers/usb_c/tcpc/rt1715.c

The PS8xxx does support SOP' and SOP''. However, the API documentation for tcpc_sop_prime_enable() indicates this command is used to enable SOP' messages, with no mention of SOP''.

The ChromeOS code that USB-C support is based on does enable SOP' and SOP'' for this command.

Do you mind updating the documentation for tcpc_sop_prime_enable() to note that this enables both SOP' and SOP''?

keith-zephyr · 2024-12-18T17:19:33Z

drivers/usb_c/tcpc/rt1715.c

This isn't correct. You're writing the TCPC register number into a pointer.

Suggested change

buf[0].buf = TCPC_REG_RX_BUFFER;

uint8_t tcpc_reg = TCPC_REG_RX_BUFFER;

buf[0].buf = *tcpc_reg;

my fault. fixed

drivers/usb_c/tcpc/ps8xxx.c

keith-zephyr

Looking good. One last ask. Please add a build test that links in this driver.

See #83187 for an example.

Locally, you can run ./scripts/twister -ivc -s drivers.usb.build.i2c to verify the test.

recalci · 2024-12-20T20:11:27Z

Looking good. One last ask. Please add a build test that links in this driver.

See #83187 for an example.

Locally, you can run ./scripts/twister -ivc -s drivers.usb.build.i2c to verify the test.

Thanks for your review.
The commit has been added. In order to ensure that everything works well together, this PR contains #83187 now. If #83187 is merged first, I will rebase and update this PR.

keith-zephyr · 2024-12-20T22:00:35Z

Looking good. One last ask. Please add a build test that links in this driver.
See #83187 for an example.
Locally, you can run ./scripts/twister -ivc -s drivers.usb.build.i2c to verify the test.

Thanks for your review. The commit has been added. In order to ensure that everything works well together, this PR contains #83187 now. If #83187 is merged first, I will rebase and update this PR.

#83187 has now merged.

recalci · 2024-12-21T14:56:57Z

Looking good. One last ask. Please add a build test that links in this driver.
See #83187 for an example.
Locally, you can run ./scripts/twister -ivc -s drivers.usb.build.i2c to verify the test.

Thanks for your review. The commit has been added. In order to ensure that everything works well together, this PR contains #83187 now. If #83187 is merged first, I will rebase and update this PR.

#83187 has now merged.

Just updated. Local tests passed.

keith-zephyr · 2024-12-26T23:42:24Z

drivers/usb_c/tcpc/ps8xxx.c

Non-blocking comment. This change isn't related to using the common tcpci functions.

drivers/usb_c/tcpc/tcpci.c

Add generic functions that will be common to all TCPCI compliant drivers. Signed-off-by: Jianxiong Gu <[email protected]>

drivers/usb_c/tcpc/rt1715.c

Add support for RT1715. Signed-off-by: Jianxiong Gu <[email protected]>

This commit modifies the ps8xxx.c driver to use the generic TCPCI function. Signed-off-by: Jianxiong Gu <[email protected]>

Clearly mention that this function enables both SOP' and SOP'' messages. Signed-off-by: Jianxiong Gu <[email protected]>

Add a build test to verify richtek,rt1715 driver builds correctly. Signed-off-by: Jianxiong Gu <[email protected]>

zephyrbot added the area: USB-C label Nov 7, 2024

zephyrbot requested review from keith-zephyr and sambhurst November 7, 2024 23:28

zephyrbot assigned sambhurst Nov 7, 2024

recalci force-pushed the usbc_tcpc_rt1715 branch 4 times, most recently from 84315d9 to 4cd7a1c Compare November 10, 2024 22:29

recalci marked this pull request as draft December 5, 2024 18:17

recalci force-pushed the usbc_tcpc_rt1715 branch from 4cd7a1c to 8796eb8 Compare December 10, 2024 15:18

recalci marked this pull request as ready for review December 10, 2024 15:21

recalci force-pushed the usbc_tcpc_rt1715 branch 2 times, most recently from 8bacd7b to 5d3b6b4 Compare December 10, 2024 15:49

keith-zephyr reviewed Dec 12, 2024

View reviewed changes

recalci force-pushed the usbc_tcpc_rt1715 branch 2 times, most recently from 55c7eb8 to a8bb603 Compare December 14, 2024 12:54

keith-zephyr reviewed Dec 18, 2024

View reviewed changes

recalci force-pushed the usbc_tcpc_rt1715 branch from a8bb603 to 6247177 Compare December 18, 2024 18:34

keith-zephyr reviewed Dec 18, 2024

View reviewed changes

recalci force-pushed the usbc_tcpc_rt1715 branch from 1d00144 to 2356a95 Compare December 20, 2024 20:05

zephyrbot added the area: USB Universal Serial Bus label Dec 20, 2024

zephyrbot requested review from jfischer-no and tmon-nordic December 20, 2024 20:05

recalci force-pushed the usbc_tcpc_rt1715 branch from 2356a95 to 77d80d3 Compare December 21, 2024 14:38

keith-zephyr previously approved these changes Dec 26, 2024

View reviewed changes

drivers/usb_c/tcpc/ps8xxx.c Outdated

Copy link

Contributor

keith-zephyr Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment. This change isn't related to using the common tcpci functions.

sambhurst reviewed Jan 9, 2025

View reviewed changes

drivers/usb_c/tcpc/tcpci.c Outdated Show resolved Hide resolved

usbc: add generic TCPCI related functions

b5b1d9e

Add generic functions that will be common to all TCPCI compliant drivers. Signed-off-by: Jianxiong Gu <[email protected]>

recalci dismissed keith-zephyr’s stale review via 19be7e8 January 10, 2025 09:50

recalci force-pushed the usbc_tcpc_rt1715 branch from 77d80d3 to 19be7e8 Compare January 10, 2025 09:50

pdgendt reviewed Jan 10, 2025

View reviewed changes

drivers/usb_c/tcpc/rt1715.c Outdated Show resolved Hide resolved

recalci added 4 commits January 13, 2025 23:18

drivers: tcpc: Add TCPC driver for RT1715

956a63d

Add support for RT1715. Signed-off-by: Jianxiong Gu <[email protected]>

drivers: tcpc: Modify the ps8xxx.c

16f22fb

This commit modifies the ps8xxx.c driver to use the generic TCPCI function. Signed-off-by: Jianxiong Gu <[email protected]>

usbc: Update tcpc_sop_prime_enable() description

286aa0c

Clearly mention that this function enables both SOP' and SOP'' messages. Signed-off-by: Jianxiong Gu <[email protected]>

tests: drivers: Add RT1715 driver

a717688

Add a build test to verify richtek,rt1715 driver builds correctly. Signed-off-by: Jianxiong Gu <[email protected]>

recalci force-pushed the usbc_tcpc_rt1715 branch from 19be7e8 to a717688 Compare January 13, 2025 15:21

sambhurst approved these changes Jan 13, 2025

View reviewed changes

keith-zephyr approved these changes Jan 15, 2025

View reviewed changes

kartben merged commit eefbed2 into zephyrproject-rtos:main Jan 15, 2025
24 checks passed

recalci deleted the usbc_tcpc_rt1715 branch January 29, 2025 11:08

	buf[0].buf = TCPC_REG_RX_BUFFER;
	uint8_t tcpc_reg = TCPC_REG_RX_BUFFER;
	buf[0].buf = *tcpc_reg;

Add TCPC driver for RT1715 #81109

Add TCPC driver for RT1715 #81109

Uh oh!

Conversation

recalci commented Nov 7, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keith-zephyr left a comment

Choose a reason for hiding this comment

Uh oh!

recalci commented Dec 20, 2024

Uh oh!

keith-zephyr commented Dec 20, 2024

Uh oh!

recalci commented Dec 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

recalci commented Dec 21, 2024 •

edited

Loading